Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to font colors in selected/unselected tabs in views and editor #2187

Closed
wants to merge 1 commit into from
Closed

Change to font colors in selected/unselected tabs in views and editor #2187

wants to merge 1 commit into from

Conversation

mvm-sap
Copy link
Contributor

@mvm-sap mvm-sap commented Aug 13, 2024

Change to the existing light theme #2114 also involved the change to the font colors of selected and unselected tabs in views and editors. This led to an issue from a user #2182.

Selected tab in Views and Editor now has #00000 color code
Unselected tabs in Views and Editor now have #3b3b3b color code
This change has been done to improve the contrast between font color and background color of tabs.
Please let us know your views.

Screenshots can be found here.

Before:
image

After:
image

@BeckerWdf
Copy link
Contributor

@jukzi: What's your opinion?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 13, 2024 •
edited
Loading

Test Results

0 files   -  1 510  0 suites   - 1 510   0s ⏱️ - 1h 1m 47s
0 tests  -  7 688  0 ✅  -  7 460  0 💤  - 228  0 ❌ ±0 
0 runs   - 22 385  0 ✅  - 21 839  0 💤  - 546  0 ❌ ±0 

Results for commit 63a0561. ± Comparison against base commit 8ad21aa.

♻️ This comment has been updated with latest results.

@jukzi
Copy link
Contributor

jukzi commented Aug 13, 2024

Looks better but still feels to pale at the inactive tabs:
image
Maybe one can get used to it. But by now i would still prefer the old contrast. I guess the subjective feeling is also because eclipse IDE still shows high contrast icons in front of the name which makes the low contrast text have less contrast then the icons. But i don't need to focus on the icons. The text is the important thing.

"VS Code" and other IDEs not have those problem because they have general other layout without icons and a low contrast content in the problem view:
image

@BeckerWdf
Copy link
Contributor

I guess the subjective feeling is also because eclipse IDE still shows high contrast icons in front of the name which makes the low contrast text have less contrast then the icons.

That's an interesting idea.
Btw: You can turn off the icons on view tabs in the preference. Then this issue no longer exists.

@jukzi
Copy link
Contributor

jukzi commented Aug 13, 2024

issue still exists because it does not disable the high contrast in the editor icons
image

@mvm-sap
Change to font colors in selected/unselected tabs in views and editor
63a0561 
Selected tabs in Views and Editor now has #000000 color code
Unselected tabs in Views and Editor now has #3b3b3b color code
This change has been done to improve the contrast between font color and
background of selected tabs
@mvm-sap mvm-sap force-pushed the Font_color_change_for_tabs_in_views_and_editors branch from 6296efb to 63a0561 Compare August 13, 2024 23:37
@BeckerWdf BeckerWdf mentioned this pull request Sep 18, 2024
Merged
@BeckerWdf
Copy link
Contributor

Replaced with #2294

@BeckerWdf BeckerWdf closed this Sep 18, 2024
@mvm-sap mvm-sap deleted the Font_color_change_for_tabs_in_views_and_editors branch September 23, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvm-sap @BeckerWdf @jukzi